| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Date: | 2018-09-17 11:49:30 |
| Message-ID: | 20180917114930.GC31460@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 14, 2018 at 12:35:54PM -0300, Alvaro Herrera wrote:
> On 2018-Sep-13, Michael Paquier wrote:
>> Improve autovacuum logging for aggressive and anti-wraparound runs
>>
>> A log message was being generated when log_min_duration is reached for
>> autovacuum on a given relation to indicate if it was an aggressive run,
>> and missed the point of mentioning if it is doing an anti-wrapround
>> run. The log message generated is improved so as one, both or no extra
>> details are added depending on the option set.
>
> Hmm, can a for-wraparound vacuum really not be aggressive? I think one
> of those four cases is really dead code.
Sure, at the same time it is a no-brainer to keep the code as is, and
seeing log messages where (!aggressive && wraparound) would be an
indication of surrounding bugs, no? There have been issues in this area
in the past.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-17 13:41:37 | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |
| Previous Message | Michael Paquier | 2018-09-17 11:41:13 | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kukushkin | 2018-09-17 12:25:56 | Re: Connection slots reserved for replication |
| Previous Message | Michael Paquier | 2018-09-17 11:41:13 | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |