| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi |
| Date: | 2018-09-14 22:49:39 |
| Message-ID: | 20180914224939.GA1178@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 14, 2018 at 11:22:55AM -0400, Tom Lane wrote:
> I'm surprised you didn't back-patch this --- isn't it a bug fix?
>
> A compromise might be to push it to v11 but not further.
Yes, that's clearly a bug fix from pg_ctl point of view with TAP tests.
However, I have rather cold feet about back-patching for two reasons as
this introduces a behavior change:
- The concurrency part disappears.
- Caller of open() needs to enforce text mode to strip correctly CRLF
characters.
I would be fine to get that into v11 though, as that is not released
yet. You will have to wait for a couple of days though, there is a long
week-end here away from laptops and electronic devices ;)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-09-15 13:14:46 | pgsql: Move PartitionDispatchData struct definition to execPartition.c |
| Previous Message | Alvaro Herrera | 2018-09-14 22:36:44 | pgsql: Move PartitionDispatchData struct definition to execPartition.c |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-09-15 00:18:44 | Re: Defaulting to jit=on/off for v11 |
| Previous Message | Jonathan S. Katz | 2018-09-14 22:47:56 | Re: Defaulting to jit=on/off for v11 |