Re: [Patch] Create a new session in postmaster by calling setsid()

From: Andres Freund <andres(at)anarazel(dot)de>
To: Paul Guo <pguo(at)pivotal(dot)io>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [Patch] Create a new session in postmaster by calling setsid()
Date: 2018-09-13 19:24:38
Message-ID: 20180913192438.et575bl6hf72bhcc@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-09-13 15:27:58 +0800, Paul Guo wrote:
> From the respective of users instead of developers, I think for such
> important
> service, tty should be dissociated, i.e. postmaster should be daemonized by
> default (and even should have default log filename?) or be setsid()-ed at
> least.

I don't think it'd be good to switch to postgres daemonizing itself. If
we were starting fresh, maybe, but there's plenty people invoking
postgres from scripts etc. And tools like systemd don't actually want
daemons to fork away, so there's no clear need from that side either.

> I'm not sure the several-years-ago LINUX_OOM_ADJ issue (to resolve that,
> silient_mode was removed) still exists or not. I don't have context about
> that, so
> I conceded to use setsid() even I prefer the deleted silent_mode code.

Yes, the OOM issues are still relevant.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kuzmenkov 2018-09-13 19:36:24 Re: Index Skip Scan
Previous Message Tom Lane 2018-09-13 19:10:42 Re: Consistent segfault in complex query