Re: PATCH: Update snowball stemmers

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Subject: Re: PATCH: Update snowball stemmers
Date: 2018-09-13 09:02:22
Message-ID: 20180913090215.GA28174@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, Sep 12, 2018 at 05:47:05PM -0400, Tom Lane wrote:
> Oh, patch(1) doesn't understand git's idea of "renaming" files, cf
>
> https://www.postgresql.org/message-id/CAEepm=2+CF3PshNRAs-r8jtPLKj0K6UEACeRSqBi5Cf74L=w7Q@mail.gmail.com
>
> I'd suggest using "git diff --no-renames", since some of us will want
> to apply the patch using patch(1).

Ah, I see. I attached new version made with --no-renames. Will wait for
what cfbot will say.

> > In my laptop there is no such problem. I tried both "git apply" and
> > "patch -p1". And I can build the patch.
>
> Really? What version of patch was that?

It is 2.7.6. It seems it was released in 2018-02-03. Not sure, but maybe
they improved support for git's file renames.

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
update_snowball_stemmers_v2.patch text/plain 972.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-09-13 09:29:31 Re: [HACKERS] Restricting maximum keep segments by repslots
Previous Message Sergei Kornilov 2018-09-13 09:00:49 Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration