Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)
Date: 2018-09-12 07:38:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Aug 10, 2018 at 02:31:25PM -0400, Tom Lane wrote:
> The cfbot points out that this has suffered bit-rot, so here's a rebased
> version --- no substantive changes.

+ /*
+ * Try to read the symlink. If not there, not a symlink, etc etc, just
+ * quietly fail; the precise reason needn't concern us.
+ */
+ len = readlink(linkname, link_target, sizeof(link_target));

One thing that I can see changing with this patch is how timezone is set
in postgresql.conf. For example, on HEAD I get 'Japan' while this patch
gives back 'Asia/Tokyo'. Could it be an issue for countries with
multiple timezones? I am not sure how Russian systems would react on
that for example.

The time cut for initdb is interesting for buildfarm members anyway, and
the patch looks in nice shape to me.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2018-09-12 08:15:48 Re: Collation versioning
Previous Message Michael Paquier 2018-09-12 07:20:49 Re: make installcheck-world in a clean environment