Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Evans <code(at)jeremyevans(dot)net>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Date: 2018-09-08 19:31:58
Message-ID: 20180908193158.GH32058@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Sep 08, 2018 at 07:56:23AM -0400, Tom Lane wrote:
> Looking closer, there are no leaks, though I think we could use a comment
> about that. And it still makes me itch that pg_saslprep (mostly) doesn't
> worry about clearing *output on failure while only three of its four
> callers bother to initialize their variables to null. That's a recipe
> for future bugs. So I propose the attached cleanup.

Okay, that looks acceptable to me. Thanks for looking at that.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-09-08 19:39:14 Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Previous Message Tom Lane 2018-09-08 19:11:15 Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables