Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Evans <code(at)jeremyevans(dot)net>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Date: 2018-09-07 20:44:03
Message-ID: 20180907204403.GC32058@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Sep 07, 2018 at 04:18:55PM -0400, Tom Lane wrote:
> I had been studying that when the report first arrived. I'm not really
> happy with the coding in pg_saslprep(): it leaves garbage in its output
> parameter in some code paths, and I think it leaks memory in others.

Agreed. Do you want to give it a go? I can see some of those code
paths? Likely you spotted more.

> But I couldn't see a path that would lead to the observed failure.

Agreed.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2018-09-07 21:33:46 BUG #15369: Postgres fails to start with default "ssl = true" configuration
Previous Message Tom Lane 2018-09-07 20:18:55 Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables