Re: Problem while setting the fpw with SIGHUP

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: amit(dot)kapila16(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, hlinnaka(at)iki(dot)fi, dilipbalaut(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Problem while setting the fpw with SIGHUP
Date: 2018-09-06 23:37:28
Message-ID: 20180906233728.GR2726@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 28, 2018 at 07:34:36PM +0900, Kyotaro HORIGUCHI wrote:
> Thanks for prompting. The difference is in a comment and I'm fine
> with the change.

/*
* Properly accept or ignore signals the postmaster might send us.
*/
- pqsignal(SIGHUP, StartupProcSigHupHandler); /* reload config file */
+ pqsignal(SIGHUP, SIG_IGN); /* ignore reload config */

I am finally coming back to this patch set, and that's one of the first
things I am going to help moving on for this CF. And this bit from the
last patch series is not acceptable as there are some parameters which
are used by the startup process which can be reloaded. One of them is
wal_retrieve_retry_interval for tuning when fetching WAL at recovery.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-09-07 00:36:15 Re: Collation versioning
Previous Message Jeremy Schneider 2018-09-06 22:58:31 Re: Have an encrypted pgpass file