| From: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [HACKERS] Custom compression methods |
| Date: | 2018-09-06 15:27:13 |
| Message-ID: | 20180906182713.502e1107@wp.localdomain |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 23 Jul 2018 16:16:19 +0300
Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> I'm going to review this patch. Could you please rebase it? It
> doesn't apply for me due to changes made in src/bin/psql/describe.c.
>
> patching file src/bin/psql/describe.c
> Hunk #1 FAILED at 1755.
> Hunk #2 FAILED at 1887.
> Hunk #3 FAILED at 1989.
> Hunk #4 FAILED at 2019.
> Hunk #5 FAILED at 2030.
> 5 out of 5 hunks FAILED -- saving rejects to file
> src/bin/psql/describe.c.rej
>
> Also, please not that PostgreSQL 11 already passed feature freeze some
> time ago. So, please adjust your patch to expect PostgreSQL 12 in the
> lines like this:
>
> + if (pset.sversion >= 110000)
>
> ------
> Alexander Korotkov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
Hi, attached latest set of patches. Rebased and fixed pg_upgrade errors
related with zlib support.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Make-syntax-changes-for-custom-compression-metho-v19.patch | text/x-patch | 9.2 KB |
| 0002-Add-compression-catalog-tables-and-the-basic-inf-v19.patch | text/x-patch | 114.5 KB |
| 0003-Add-rewrite-rules-and-tupdesc-flags-v19.patch | text/x-patch | 24.4 KB |
| 0004-Add-pglz-compression-method-v19.patch | text/x-patch | 7.6 KB |
| 0005-Add-zlib-compression-method-v19.patch | text/x-patch | 10.0 KB |
| 0006-Add-psql-pg_dump-and-pg_upgrade-support-v19.patch | text/x-patch | 34.8 KB |
| 0007-Add-tests-for-compression-methods-v19.patch | text/x-patch | 150.6 KB |
| 0008-Add-documentation-for-custom-compression-methods-v19.patch | text/x-patch | 17.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Finzel | 2018-09-06 15:40:55 | Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data |
| Previous Message | Thomas Munro | 2018-09-06 14:49:32 | Re: remove ancient pre-dlopen dynloader code |