| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Postgres commits <pgsql-committers(at)postgresql(dot)org>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
| Date: | 2018-09-06 05:52:19 |
| Message-ID: | 20180906055219.GJ2726@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Sep 06, 2018 at 06:26:51AM +0100, Andrew Gierth wrote:
> What version of GNU Make is on there, do you know? Tom? I don't see it
> mentioned in the output anywhere.
I don't know it. What I can see is that the use of "else ifdef" is
forbidden. You could bypass the problem with more ifdef-only tweaks,
but it seems to me that it would be cleaner to somewhat reduce the level
of dependency between all the different header concepts.
By the way, when you use at least two layers in ifdef/endif in pgxs.mk,
putting a comment close to the endif to mention which part gets closed
improves readability.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-09-06 06:09:19 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
| Previous Message | Andrew Gierth | 2018-09-06 05:26:51 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-09-06 06:09:19 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
| Previous Message | Kyotaro HORIGUCHI | 2018-09-06 05:49:49 | Re: Problem while updating a foreign table pointing to a partitioned table on foreign server |