Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

On 2018-Sep-05, Michael Paquier wrote:

> On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote:
> > Should this be used in src/test/modules/{brin,test_commit_ts} also?
>
> Hmm, I have not thought those two ones. commit_ts relies on REGRESS to
> be defined so as it does its cleanup. brin is more interesting, it
> directly quotes that it needs to tweak its Makefile to do the cleanup,
> and it uses isolation tests. Wouldn't it be more adapted to add a
> second extra switch for isolation tests similar to REGRESS? We could
> call it ISOLATION, and it would list the set of isolation tests you
> could run from an extension. That would be useful for a lot of folks.
>
> Thoughts?

Yeah, +1 for that.

> It would be better to start a new thread rather than posting
> a new patch, but I'd rather take the temperature first.

Slightly feverish, it appears.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services