| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_verify_checksums and -fno-strict-aliasing |
| Date: | 2018-09-01 23:19:00 |
| Message-ID: | 20180901231900.GF5305@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 01, 2018 at 03:32:10PM -0400, Tom Lane wrote:
> Fair enough. I renamed the types as suggested, changed a few more
> places for consistency's sake, and pushed.
Thanks!
> There still remain some places where palloc(BLCKSZ) or equivalent is used,
> but there's no matching pfree. In a lot of them the buffer is returned
> to the caller so there's no choice. It's likely that some are just
> leaking the storage transiently and we could convert them to using a
> PGAlignedBlock local variable, but I didn't bother trying to do the
> analysis.
At quick glance, I am not seeing anything critical. So the result looks
good to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2018-09-02 00:07:21 | Re: Loaded footgun open_datasync on Windows |
| Previous Message | Noah Misch | 2018-09-01 22:49:42 | Re: Configuring messages language on Windows |