| From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option) |
| Date: | 2018-08-30 08:35:09 |
| Message-ID: | 20180830173509.5905d868f273364b3e9bfc39@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Aug 2018 10:13:31 +0200
Michael Banck <michael(dot)banck(at)credativ(dot)de> wrote:
> Hi,
>
> thanks for fixing this up!
>
> On Wed, Aug 29, 2018 at 11:25:28PM +0900, Yugo Nagata wrote:
> > diff --git a/doc/src/sgml/ref/pg_verify_checksums.sgml b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > index ecc5501eae..a1ff060c2b 100644
> > --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> > +++ b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > @@ -64,8 +64,8 @@ PostgreSQL documentation
> > <term><option>-d</option></term>
>
> This -d needs to be renamed to -v as well I guess.
>
> > <listitem>
> > <para>
> > - Enable debug output. Lists all checked blocks and their checksum.
> > - </para>
> > + Enable debug output. Lists all checked files.
>
> I'd say 'Enable verbose output.' would be more appropriate now.
>
> Looks good to me otherwise.
Thank you for your review. I forgot the doc fix.
Attached is the updated patch.
Regards,
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
| Attachment | Content-Type | Size |
|---|---|---|
| 01_pg_veriify_checksum_debug_to_verbose-v3.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2018-08-30 08:48:24 | Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option) |
| Previous Message | Michael Banck | 2018-08-30 08:35:00 | pg_verify_checksums and -fno-strict-aliasing |