Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: abelisto(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Date: 2018-08-21 01:19:49
Message-ID: 20180821011949.r5ogh32qluf56na6@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2018-Aug-21, David Rowley wrote:

> > To reproduce:
> > $ createdb foo
> > $ psql foo -c "create table bar(i int generated by default as identity
> > primary key);"
> > $ pg_dump foo --exclude-table=bar
> > Segmentation fault (core dumped)

> I think the fix depends exactly on what we want the behaviour to be
> here. Should dumpSequence() still dump out a CREATE SEQUENCE
> statement for this, or should we just ignore the sequence? I imagine
> we should just ignore identity sequences when we're not going to dump
> the table that owns them. It looks like that would require a small
> modification in getOwnedSeqs().

Yeah, we should omit the sequence too. I don't see any principled
reason to think that the sequence is interesting on its own.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-08-21 01:49:44 Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Previous Message David Rowley 2018-08-21 00:37:03 Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column