| From: | Nico Williams <nico(at)cryptonector(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allowing printf("%m") only where it actually works |
| Date: | 2018-08-19 18:27:05 |
| Message-ID: | 20180819182704.GC16780@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 19, 2018 at 01:15:58AM -0400, Tom Lane wrote:
> Nico Williams <nico(at)cryptonector(dot)com> writes:
> > On Sat, Aug 18, 2018 at 04:34:50PM -0400, Tom Lane wrote:
> >> So now I'm about ready to propose that we just *always* use
> >> snprintf.c, and forget all of the related configure probing.
>
> > You'd also get to ensure that all uses from *die() are
> > async-signal-safe.
>
> [ raised eyebrow... ] That seems like more than I care to promise
> here. But even if snprintf itself were unconditionally safe,
> there's plenty of other stuff in that code path that isn't.
One step at a time, no? And there's the other benefits.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-19 19:12:00 | Re: Allowing printf("%m") only where it actually works |
| Previous Message | Jonathan S. Katz | 2018-08-19 17:29:15 | Re: Fix for REFRESH MATERIALIZED VIEW ownership error message |