Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Dave Cramer <pg(at)fastcrypt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Date: 2018-08-19 03:59:19
Message-ID: 20180819035919.fplpxx2jkazi32vu@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Aug-18, Jonathan S. Katz wrote:

>
> > On Aug 18, 2018, at 8:52 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
> >
> >>
> >> On Aug 18, 2018, at 8:45 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >>
> >> I am not so sure about v11 as it is very close to release, surely we can
> >> do something for HEAD as that's cosmetic. Anyway, if something is
> >> proposed, could a patch be posted? The only patch I am seeing on this
> >> thread refers to improvements for error messages of procedures.
> >
> > Oops, too much multitasking. I will attach the correct patch when I get home.
>
> Here is the correct patch, sorry about that. This includes aforementioned
> tests.

I ran the test without the code change, and it passes. I don't think
it's testing what you think it is testing.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masayuki Takahashi 2018-08-19 04:28:34 Re: How to estimate the shared memory size required for parallel scan?
Previous Message Jonathan S. Katz 2018-08-19 02:02:08 Re: Fix for REFRESH MATERIALIZED VIEW ownership error message