|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||"Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>|
|Cc:||pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Fix for REFRESH MATERIALIZED VIEW ownership error message|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2018-Aug-17, Jonathan S. Katz wrote:
> I Initially pointed out here that running REFRESH MATERIALIZED VIEW as a
> non-superuser or table owner yields the following message:
> test=> REFRESH MATERIALIZED VIEW blah;
> ERROR: must be owner of relation blah
> The error message should say "...owner of materialized view..."
> The attached patch corrects this by setting the "relkind" for the
> REFRESH MATERIALIZED VIEW command to be "OBJECT_MATVIEW" so that the aclcheck
> returns the appropriate error message. The updated patch can be tested as such:
> CREATE ROLE bar LOGIN;
> CREATE TABLE a (x int);
> CREATE MATERIALIZED VIEW b AS SELECT * FROM a;
> \c - bar
> REFRESH MATERIALIZED VIEW b;
> ERROR: must be owner of materialized view b
> I'm happy to generate the backpatches for it but wanted to receive feedback
Maybe add your test to some regress/ file?
As it is cosmetic, my inclination would be not to backpatch it.
However, I don't quite see how this patch can possibly fix the problem,
since the new struct member is not used anywhere AFAICT.
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Wu Ivy||2018-08-17 23:25:05||Getting NOT NULL constraint from pg_attribute|
|Previous Message||Tom Lane||2018-08-17 21:23:09||Re: [PATCH] Improve geometric types|