Re: remove ancient pre-dlopen dynloader code

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: remove ancient pre-dlopen dynloader code
Date: 2018-08-16 13:59:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > This now generates a super nitpicky warning on at at least some linux +
> > clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> > change added:
> > dynloader.c:7:4: warning: ISO C requires a translation unit to contain at least one declaration [-Wempty-translation-unit]
> We've been seeing that (or equivalents) on other platforms for years,
> if not decades. I can't get too excited about it really.

Yea, me neither.

> The lazy man's way to get rid of it would be to put something like
> "int bogus = 0;" in the empty dynloader.c files. Better would be
> to not have the empty .c files at all, but I'm not sure how much
> we'd have to contort the Makefiles to support that.

If I had my druthers, we'd just remove all that configure magic for
selecting these files and just use ifdefs. Personally I find it
occasionally that they're linked into place, rather than built under
their original name.


Andres Freund

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-16 14:07:04 Re: remove ancient pre-dlopen dynloader code
Previous Message Liudmila Mantrova 2018-08-16 13:57:41 Re: [HACKERS] Bug in to_timestamp().