Re: C99 compliance for src/port/snprintf.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: C99 compliance for src/port/snprintf.c
Date: 2018-08-16 12:30:50
Message-ID: 20180816123050.2hk6ppwe2ij3dxpg@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Hi,

On 2018-08-16 14:26:07 +0200, Peter Eisentraut wrote:
> On 16/08/2018 13:18, Andres Freund wrote:
> > checking for ccache gcc option to accept ISO C99... unsupported
> >
> > I suspect that's because of the '-ansi' flag in CFLAGS, not because
> > the compiler is incapable of actually supporting C99.
>
> -ansi is equivalent to -std=c90. If we make the switch, the build farm
> configuration should just probably replace -ansi with -std=c99.

Right. I just hadn't checked the addition of -std=c99 doesn't override
the -ansi. Presumably just an ordering thing.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-16 12:54:17 Re: C99 compliance for src/port/snprintf.c
Previous Message Peter Eisentraut 2018-08-16 12:28:25 Re: C99 compliance for src/port/snprintf.c

Browse pgsql-www by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-16 12:54:17 Re: C99 compliance for src/port/snprintf.c
Previous Message Peter Eisentraut 2018-08-16 12:28:25 Re: C99 compliance for src/port/snprintf.c