A dubious message related to SP-GiST compress method.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: A dubious message related to SP-GiST compress method.
Date: 2018-08-10 01:07:42
Message-ID: 20180810.100742.15469435.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I ran across the followin gcode in spgutils.c.

> if (OidIsValid(cache->config.leafType) &&
> cache->config.leafType != atttype)
> {
> if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("compress method must not defined when leaf type is different from input type")));
> fillTypeDesc(&cache->attLeafType, cache->config.leafType);

IIUC the fourth line looks inconsistent with the message in 7th
line. Compress methos is required in the case. Isn't "must not
defined" a typo of "must be defined"?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
spguilts_msg.patch text/x-patch 664 bytes

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-08-10 01:32:58 Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Previous Message Bruce Momjian 2018-08-10 00:58:59 Re: POC for a function trust mechanism