Re: libpq should append auth failures, not overwrite

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: libpq should append auth failures, not overwrite
Date: 2018-08-09 16:14:53
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Aug 09, 2018 at 11:44:27AM -0400, Tom Lane wrote:
> I noticed that, although most error reports during libpq's connection
> setup code append to conn->errorMessage, the ones in fe-auth.c and
> fe-auth-scram.c don't: they're all printfPQExpBuffer() not
> appendPQExpBuffer(). This seems wrong to me. It makes no difference
> in simple cases with a single target server, but as soon as you have
> multiple servers listed in "host", this coding makes it impossible
> to tell which server rejected your login.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-08-09 16:19:01 Commitfest 2018-07 RFC items
Previous Message Bruce Momjian 2018-08-09 16:11:48 Re: found xmin from before relfrozenxid on pg_catalog.pg_authid