From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "berge(at)trivini(dot)no" <berge(at)trivini(dot)no>, Gürkan Gür <ben(at)gurkan(dot)in>, Raimund Schlichtiger <raimund(dot)schlichtiger(at)innogames(dot)com>, Bernhard Schrader <bernhard(dot)schrader(at)innogames(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Vik Fearing <vik(at)2ndquadrant(dot)fr> |
Subject: | Re: Standby trying "restore_command" before local WAL |
Date: | 2018-08-08 16:15:51 |
Message-ID: | 20180808161551.GL27724@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greetings,
* David Steele (david(at)pgmasters(dot)net) wrote:
> I can see cases where it *might* be worth it, but several backup tools
> support prefetch and/or parallelism which should be able to keep
> Postgres fed with WAL unless there is very high latency to the repo.
> I'm not sure the small performance boost (if any) would be enough to
> justify the extra code paths and tests.
...
> That said, if there is anything we can do in core to make these tools
> simpler or more performant I'm all for it. For instance, it might be
> good to have return code (as suggested upstream) that indicates to
> Postgres that the segment in pg_wal is a good choice. Some use cases
> might benefit enormously even if it doesn't make sense as a general case.
Well, if there are some use cases that would benefit greatly from it
then it may just be worth it. That said, it doesn't sound like a common
enough ask to be something we'd prioritize for pgbackrest, at least not
without actual client demand/interest in it. If someone else wants to
write the tests and the code and contribute that capability, we'd
certainly welcome it.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2018-08-08 16:19:34 | Re: [HACKERS] possible self-deadlock window after bad ProcessStartupPacket |
Previous Message | David Steele | 2018-08-08 16:03:58 | Re: Standby trying "restore_command" before local WAL |