Re: Alter index rename concurrently to

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrey Klychkov <aaklychkov(at)mail(dot)ru>, Victor Yegorov <vyegorov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Alter index rename concurrently to
Date: 2018-08-01 19:36:16
Message-ID: 20180801193616.gi7mfs4kn5kggamf@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-08-01 15:33:09 -0400, Robert Haas wrote:
> On Wed, Aug 1, 2018 at 3:04 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > On 31/07/2018 23:25, Tom Lane wrote:
> >> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> >>> On 27/07/2018 16:16, Robert Haas wrote:
> >>>> I also suspect that an appropriate fix might be to ensure that
> >>>> AcceptInvalidationMessages() is run at least once at the beginning of
> >>>> parse analysis.
> >>
> >>> Why don't we just do that?
> >>
> >> Don't we do that already? Certainly it should get run in advance of
> >> any relation name lookup. There is one at transaction start also,
> >> if memory serves.
> >
> > Right, we do it at transaction start and when opening a relation with a
> > lock that you don't already have. Which I suppose in practice is almost
> > equivalent to at least once per command, but you can construct cases
> > where subsequent commands in a transaction use the all same tables as
> > the previous commands, in which case they don't run AIM() again.
>
> Right. If nobody sees a reason not to change that, I think we should.
> It would make the behavior more predictable with, I hope, no real
> loss.

What precisely are you proposing?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2018-08-01 19:55:18 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Robert Haas 2018-08-01 19:33:09 Re: Alter index rename concurrently to