Re: Documentaion fix.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: michael(at)paquier(dot)xyz
Cc: alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Documentaion fix.
Date: 2018-08-01 04:04:37
Message-ID: 20180801.130437.216808601.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 1 Aug 2018 02:47:32 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20180731174732(dot)GD2878(at)paquier(dot)xyz>
> On Tue, Jul 31, 2018 at 10:59:14AM -0400, Alvaro Herrera wrote:
> > How about pasting it like this?
> >
> > alvherre=# select * from pg_replication_slots \gx
> > ─[ RECORD 1 ]───────┬────────────
> > slot_name │ node_a_slot
> > plugin │
> > slot_type │ physical
> > datoid │
> > database │
> > temporary │ f
> > active │ f
> > active_pid │
> > xmin │
> > catalog_xmin │
> > restart_lsn │
> > confirmed_flush_lsn │
>
> Each time this catalog is changed, this would become incorrect. My
> suggestion would be to change the query to that and call it a day:
> SELECT slot_name, slot_type, active FROM pg_replication_slots;

Yeah, I'm also concerned about the unstability. I didn't came up
with a list of columns that makes sense at that time but I
rethought on that.

> slot_name │ required
> plugin │ <not requried for physical slots>
> slot_type │ required
> datoid │ <not requried>
> database │ <not requried>
> temporary │ <not requried>
> active │ required?
> active_pid │ <not requried>
> xmin │ <not requried>
> catalog_xmin │ <not requried>
> restart_lsn │ better to be shown?
> confirmed_flush_lsn │ <not requried for physical slots>

The query and the result with four columns fit the current width.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v2-0001-Documentation-fix-of-Log-Shipping_95_94.patch text/x-patch 1.4 KB
v2-0001-Documentation-fix-of-Log-Shipping_mst-96.patch text/x-patch 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2018-08-01 04:17:27 Re: Should contrib modules install .h files?
Previous Message Paul Guo 2018-08-01 03:56:30 Re: pg_ugprade test failure on data set with column with default value with type bit/varbit