|From:||Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>|
|Subject:||Re: Adding a note to protocol.sgml regarding CopyData|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Thank you for the comment.
> Hello Tatsuo-san,
> Minor suggestions, although I'm not a native English speaker.
>> In libpq.sgml following is stated:
>> Before <productname>PostgreSQL</productname> protocol 3.0, it was
>> for the application to explicitly send the two characters
>> <literal>\.</literal> as a final line to indicate to the server that
> ISTM That "it" may refer to the server... Put "the application"
>> finished sending <command>COPY</command> data. While this still
>> works, it is deprecated and the
>> special meaning of <literal>\.</literal> can be expected to be removed
>> in a
>> future release.
> Maybe be more assertive, "will be removed"?
>> It is sufficient to call <function>PQendcopy</function> after
> "It is now sufficient ..."?
Well, I did not intend to enhance libpq.sgml but maybe your points is
valid (I cannot judge because I am not an native English speaker).
So I am include your point to the patch and wait for feed back from
(possibly) native English speakers.
I also added to September commit fest, including you as a reviewer.
SRA OSS, Inc. Japan
|Next Message||MyungKyu LIM||2018-07-31 08:56:57||[Todo item] Add entry creation timestamp column to pg_stat_replication|
|Previous Message||Alexander Lakhin||2018-07-31 07:10:12||Re: make installcheck-world in a clean environment|