Re: Inconsistent error message in bt_page_items_bytea().

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistent error message in bt_page_items_bytea().
Date: 2018-07-29 14:53:46
Message-ID: 20180729145346.GC1471@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 27, 2018 at 05:13:37PM +0530, Ashutosh Sharma wrote:
> All the pageinspect functions dealing with raw page has the error
> message as "must be superuser to use raw page function" however,
> that's not true for bt_page_items_bytea() which has "must be
> superuser to use pageinspect functions". This seems to me like a copy
> paste error which got transferred from bt_page_items (the function
> that doesn't deal with raw page).

Agreed. get_raw_page_internal() mentions "must be superuser to use raw
functions" which is inconsistent with the rest, so I fixed this second
one and pushed. Thanks!
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-29 14:55:01 Re: add verbosity to pg_basebackup for sync
Previous Message Jeff Janes 2018-07-29 14:45:10 Re: add verbosity to pg_basebackup for sync