| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: LLVM jit and matview |
| Date: | 2018-07-25 23:48:26 |
| Message-ID: | 20180725234826.v4yfxwgggosbli4i@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2018-07-25 18:59:51 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote:
> >> But what would be the advantage of avoiding the context release inside
> >> FreeExecutorState? It seems pretty appropriate to me to do it there.
> >> You could argue that the JIT context is definitely part of the estate
> >> being freed. Just amend the comment, no?
>
> > I agree it's right to do it there. I think I'm more questioning whether
> > there's even a need to adapt the comment, given it's really a local
> > memory resource. But I guess I'll just add a 'and ...' after
> > "ExprContexts within the EState".
>
> +1. Clarity is good.
Pushed something along those lines.
Thanks again Dmitry for reporting the issue!
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris | 2018-07-26 03:15:51 | Re: pgAdmin 4 not opening |
| Previous Message | Andres Freund | 2018-07-25 23:37:26 | Re: could not read block 0 in file : read only 0 of 8192 bytes when doing nasty on immutable index function |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2018-07-25 23:58:12 | Re: Alter index rename concurrently to |
| Previous Message | Andres Freund | 2018-07-25 23:07:36 | Re: buildfarm: could not read block 3 in file "base/16384/2662": read only 0 of 8192 bytes |