| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: LLVM jit and matview |
| Date: | 2018-07-25 22:39:38 |
| Message-ID: | 20180725223938.c5x2gkyum4t4tgxy@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2018-Jul-25, Andres Freund wrote:
> On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote:
> > On 2018-Jul-25, Andres Freund wrote:
> > But what would be the advantage of avoiding the context release inside
> > FreeExecutorState? It seems pretty appropriate to me to do it there.
> > You could argue that the JIT context is definitely part of the estate
> > being freed. Just amend the comment, no?
>
> I agree it's right to do it there.
Ok.
> I think I'm more questioning whether there's even a need to adapt the
> comment, given it's really a local memory resource. But I guess I'll
> just add a 'and ...' after "ExprContexts within the EState".
Yeah, adding two words there sounds good.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-25 22:59:51 | Re: LLVM jit and matview |
| Previous Message | Andres Freund | 2018-07-25 22:13:58 | Re: LLVM jit and matview |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-07-25 22:46:23 | Re: Scariest patch tournament, PostgreSQL 11 edition |
| Previous Message | Andres Freund | 2018-07-25 22:13:58 | Re: LLVM jit and matview |