| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: cached plans and enable_partition_pruning |
| Date: | 2018-07-23 16:03:32 |
| Message-ID: | 20180723160332.5hawct6hxda6tw4q@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jul-24, Amit Langote wrote:
> On Mon, Jul 23, 2018 at 11:20 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I think it's correct to check the plan time value, rather than the
> > execution time value. Other enable_* GUCs also take effect there, and I
> > don't see a problem with that?
>
> Ah, so that may have been intentional. Although, I wonder if
> enable_partition_pruning could be made to work differently than other
> enable_* settings, because we *can* perform pruning which is an
> optimization function even during execution, whereas we cannot modify
> the plan in other cases?
Well, let's discuss the use-case for doing that. We introduced the GUC
to cover for the case of bugs in the pruning code (and even then there
was people saying we should remove it.) Why would you have the GUC
turned on during planning but off during execution?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-23 16:08:16 | Re: Remove psql's -W option |
| Previous Message | Robert Haas | 2018-07-23 16:03:15 | Re: pgbench - remove double declaration of hash functions |