| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com> |
| Subject: | Re: Add SKIP LOCKED to VACUUM and ANALYZE |
| Date: | 2018-07-23 03:10:58 |
| Message-ID: | 20180723031058.GE2854@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 19, 2018 at 10:54:23AM +0900, Michael Paquier wrote:
> If you can get this refactoring done, let's look into getting those two
> parts committed first to simplify the next steps. No need to extend the
> grammar of cluster either. The set of options for CLUSTER should be a
> separate enum list on top of ClusterStmt in parsenodes.h, as VACUUM has
> no recheck option. I would recommend to get cluster_rel reshaped first,
> and the ereport() calls done after.
The refactoring for CLUSTER is pretty obvious, and makes the API a bit
cleaner, so attached is a proposal of patch to do so. Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactor-ClusterStmt-to-handle-more-options.patch | text/x-diff | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-23 03:24:05 | Re: Should contrib modules install .h files? |
| Previous Message | Chenxi Li | 2018-07-23 03:08:04 | code of partition split |