| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alex Tokarev <dwalin(at)dwalin(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-performance(at)postgresql(dot)org |
| Subject: | Re: Faster str to int conversion (was Table with large number of int columns, very slow COPY FROM) |
| Date: | 2018-07-20 16:45:10 |
| Message-ID: | 20180720164510.dvexjhtutylozmhj@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-performance |
Hi,
On 2018-07-20 08:27:34 -0400, Robert Haas wrote:
> On Thu, Jul 19, 2018 at 4:32 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> 1. Why the error message changes? If there's a good reason, it should
> >> be done as a separate commit, or at least well-documented in the
> >> commit message.
> >
> > Because there's a lot of "invalid input syntax for type %s: \"%s\"",
> > error messages, and we shouldn't force translators to have separate
> > version that inlines the first %s. But you're right, it'd be worthwhile
> > to point that out in the commit message.
>
> It just seems weird that they're bundled together in one commit like this.
I'll push it separately.
> Nothing else from me...
Thanks for looking!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2018-07-20 17:05:04 | Re: Negotiating the SCRAM channel binding type |
| Previous Message | Tom Lane | 2018-07-20 15:34:57 | Re: pread() and pwrite() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2018-07-23 00:07:16 | Re: Why HDD performance is better than SSD in this case |
| Previous Message | Robert Haas | 2018-07-20 12:27:34 | Re: Faster str to int conversion (was Table with large number of int columns, very slow COPY FROM) |