| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, sk(at)zsrv(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: [HACKERS] Restricting maximum keep segments by repslots |
| Date: | 2018-07-20 04:25:20 |
| Message-ID: | 20180720042520.GD7023@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 20, 2018 at 10:13:58AM +0900, Masahiko Sawada wrote:
> Also, I'm not sure it's a good way to show the distance as LSN. LSN is
> a monotone increasing value but in your patch, a value of the "remain"
> column can get decreased.
If that can happen, I think that this is a very, very bad idea. A
couple of code paths, including segment recycling and the new WAL
advancing rely on such monotonic properties. That would be also very
confusing for any monitoring job looking at pg_replication_slots.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-20 04:49:35 | Re: de-deduplicate code in DML execution hooks in postgres_fdw |
| Previous Message | Tom Lane | 2018-07-20 04:15:07 | Re: Possible performance regression in version 10.1 with pgbench read-write tests. |