From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, konstantin knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Possible bug in logical replication. |
Date: | 2018-07-19 03:18:14 |
Message-ID: | 20180719031814.GG3411@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 18, 2018 at 10:45:27PM -0400, Alvaro Herrera wrote:
> On 2018-Jul-19, Michael Paquier wrote:
>
>> On Wed, Jul 18, 2018 at 02:30:53PM -0400, Alvaro Herrera wrote:
>> > In the immortal words of Julian Bream: "yeah, I didn't like any of
>> > that".
>>
>> One wikipedia lookup later, I still don't know where this quote comes
>> from, but at least I understand who the man is.
>
> https://twitter.com/alvherre/status/1019652397306703873
>
> OK, maybe not that "immortal" after all.
:)
>> This is referring to the system catalog field in pg_replication_slots.
>
> Yeah, I think that's a bit misleading. (I very frequently do a tag-jump
> on identifiers in comments, and it's uncomfortable that in this case it
> jumps to the Docbook source rather than to the struct declaration.)
Okay, this makes sense as well and that's easier to grep.
>>> + gotrecord = XLogReadRecord(ctx->reader, startlsn, &errm) != NULL;
>>
>> I would put parenthesis for clarity.
>
> Or just put it back as a record pointer.
I am fine either way if you want to have the last call. So please feel
free to choose what you prefer here. That's no big deal.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-07-19 03:19:11 | Re: Have an encrypted pgpass file |
Previous Message | Michael Paquier | 2018-07-19 03:14:36 | Re: More consistency for some file-related error message |