Re: missing toast table for pg_policy

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: John Naylor <jcnaylor(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: missing toast table for pg_policy
Date: 2018-07-18 04:02:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jul 17, 2018 at 06:03:26PM +0900, Michael Paquier wrote:
> On Tue, Jul 17, 2018 at 02:55:07PM +0700, John Naylor wrote:
>> I didn't dig deeper, since TOAST and the large object facility are
>> mutually exclusive so there shouldn't be a toast table here anyway.
>> Hope this helps.
> [... digging ...]
> This comes from get_rel_infos where large objects are treated as user
> data. Rather than the comment you added, I would rather do the
> following:
> "Large object catalogs and toast tables are mutually exclusive and large
> object data is handled as user data by pg_upgrade, which would cause
> failures."

So, I have been playing with the previous patch and tortured it through
a couple of upgrade scenarios, where it proves to work. Attached is an
updated patch which adds toast tables except for pg_class, pg_attribute,
pg_index and pg_largeobject* with a proposal of commit message. Any
objections for the commit of this stuff?

Attachment Content-Type Size
0001-Add-toast-tables-to-most-system-catalogs.patch text/x-diff 11.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2018-07-18 04:07:27 Re: AtEOXact_ApplyLauncher() and subtransactions
Previous Message Kyotaro HORIGUCHI 2018-07-18 03:42:20 Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"