Re: missing toast table for pg_policy

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: John Naylor <jcnaylor(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: missing toast table for pg_policy
Date: 2018-07-14 12:13:45
Message-ID: 20180714121345.GA1179@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 14, 2018 at 03:47:38PM +0700, John Naylor wrote:
> I hope you don't mind, but since it might be tedious to piece together
> the addenda I left behind in this thread, I thought it might be useful
> to update Joe's patch. The attached was rebased over the new
> regression test, passes the pg_upgrade test, and has a draft commit
> message.

The test added by ecd6b434 is very helpful. Looking at the patch, this
seems sane to me. pg_upgrade run with different past versions is
proving to pass properly, and we don't want to have toast tables for
large object catalogs. It is nice that you took care of putting things
in a consistent order in IsSharedRelation().
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Julian Markwort 2018-07-14 12:47:37 Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full
Previous Message Peter Eisentraut 2018-07-14 11:15:46 Re: Segfault logical replication PG 10.4