| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robbie Harwood <rharwood(at)redhat(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, hlinnaka <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Fix some error handling for read() and errno |
| Date: | 2018-07-13 23:47:12 |
| Message-ID: | 20180713234712.GA2027@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 13, 2018 at 11:31:31AM -0400, Alvaro Herrera wrote:
>> Mr. Robot has been complaining about this patch set, so attached is a
>> rebased version. Thinking about it, I would tend to just merge 0001 and
>> give up on 0002 as that may not justify future backpatch pain. Thoughts
>> are welcome.
>
> I vote to push both.
Thanks! Did you look at the code? The first patch is just some
cleanup, while the second could have adjustments? For the second I went
with the minimal amount of work, and actually there is no need to make
ReadTransientFile() return a status per my study of ReadTwoPhaseFile()
in https://postgr.es/m/20180709050309.GM1467@paquier.xyz which must fail
when reading the file. So patch 0002 depends on the other 2PC patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pierre Ducroquet | 2018-07-14 00:00:22 | Re: [PATCH] LLVM tuple deforming improvements |
| Previous Message | David Rowley | 2018-07-13 23:25:25 | Re: Generating partitioning tuple conversion maps faster |