Re: pg_create_logical_replication_slot returns text instead of name

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_create_logical_replication_slot returns text instead of name
Date: 2018-07-12 13:18:53
Message-ID: 20180712131853.GD1167@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 12, 2018 at 07:00:48PM +0900, Masahiko Sawada wrote:
> The documentation[1] says that both pg_create_logical_replication_slot
> and pg_create_physical_replication_slot returns slot_name as a name
> type. But only pg_create_logical_replication_slot returns it as text
> type. I think these should be united as the name type. Attached small
> patch fixes it.
>
> [1] https://www.postgresql.org/docs/devel/static/functions-admin.html#FUNCTIONS-REPLICATION

That's a small thing, but I agree with you. As far as I can see slot
names are always mapped with the name type. I'll push that tomorrow if
there are no objections.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-07-12 13:24:44 Re: Binary difference in pg_internal.init after running pg_initdb multiple times
Previous Message Michael Paquier 2018-07-12 13:10:56 Re: Negotiating the SCRAM channel binding type