| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, petr(at)2ndquadrant(dot)com, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Non-reserved replication slots and slot advancing |
| Date: | 2018-07-09 18:48:28 |
| Message-ID: | 20180709184828.5mrujf7tnbjgdrqt@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jul-09, Andres Freund wrote:
> On 2018-07-09 15:48:33 +0900, Michael Paquier wrote:
> > + if (XLogRecPtrIsInvalid(MyReplicationSlot->data.restart_lsn))
> > + {
> > + ReplicationSlotRelease();
> > + ereport(ERROR,
> > + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> > + errmsg("cannot move slot not reserving WAL")));
> > + }
> > +
>
> I don't like this error message. It's unclear what refers to exactly
> what. Nor is "move" a terminology used otherwise. How about:
> "cannot advance replication slot that has not previously reserved WAL"
> or something similar?
>
> Also, ERRCODE_FEATURE_NOT_SUPPORTED doesn't quite seem right. How about
> ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE?
+1 to both of Andres' suggestions.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-07-09 18:57:24 | Re: no partition pruning when partitioning using array type |
| Previous Message | Andres Freund | 2018-07-09 18:39:09 | Re: Non-reserved replication slots and slot advancing |