| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com |
| Subject: | Re: Let's remove DSM_IMPL_NONE. |
| Date: | 2018-07-09 01:49:19 |
| Message-ID: | 20180709014919.GH1467@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 06, 2018 at 11:08:02PM +0200, Peter Eisentraut wrote:
> On 26.06.18 09:10, Kyotaro HORIGUCHI wrote:
>> --- a/src/include/storage/dsm_impl.h
>> +++ b/src/include/storage/dsm_impl.h
>> @@ -14,11 +14,10 @@
>> #define DSM_IMPL_H
>>
>> /* Dynamic shared memory implementations. */
>> -#define DSM_IMPL_NONE 0
>> -#define DSM_IMPL_POSIX 1
>> -#define DSM_IMPL_SYSV 2
>> -#define DSM_IMPL_WINDOWS 3
>> -#define DSM_IMPL_MMAP 4
>> +#define DSM_IMPL_POSIX 0
>> +#define DSM_IMPL_SYSV 1
>> +#define DSM_IMPL_WINDOWS 2
>> +#define DSM_IMPL_MMAP 3
>
> I would avoid renumbering here. It was kind of sensible to have NONE =
> 0, so I'd keep the non-NONE ones as non-zero.
+1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-09 01:59:17 | Re: no partition pruning when partitioning using array type |
| Previous Message | Michael Paquier | 2018-07-09 01:47:53 | Re: pgsql: Add wait event for fsync of WAL segments |