| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use access() to check file existence in GetNewRelFileNode() |
| Date: | 2018-07-09 01:36:34 |
| Message-ID: | 20180709013634.GF1467@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Jul 08, 2018 at 10:27:33AM -0700, Andres Freund wrote:
> On 2018-07-08 10:05:53 -0400, Andrew Dunstan wrote:
>> I think if you're the committer you're assumed to have reviewed the patch
>> :-)
>
> I personally think it makes sense to put oneself there. At least I order
> the Reviewed-By etc lists roughly by the amount of work done. Sometimes
> you come across a patch where others have done most of the review work,
> so it's sensible to put yourself last. In other cases you might have
> spent months of effort - so first.
Yeah, that's my line of thoughts as well. So it is not strange to me
either to put oneself in any lists if adapted.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-09 01:47:43 | pgsql: Fix table format in documentation for I/O wait events |
| Previous Message | Michael Paquier | 2018-07-09 01:29:21 | pgsql: Rework order of end-of-recovery actions to delay timeline histor |