Re: pgsql: Add wait event for fsync of WAL segments

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add wait event for fsync of WAL segments
Date: 2018-07-03 22:32:20
Message-ID: 20180703223220.GA1672@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 03, 2018 at 04:12:23PM -0400, Alvaro Herrera wrote:
> On 2018-Jul-03, Andres Freund wrote:
>
> > On 2018-07-03 15:13:20 -0400, Alvaro Herrera wrote:
> > > Are the numerical values actually exposed to the world? I thought the
> > > only way to this info was through the system views, which surely expose
> > > the names, not the numbers.
> >
> > There's at least some work at high frequency sampling of these, and I
> > assume that's not going through SQL, but rather C functions.
>
> You're right.

My take is a background worker which connects to shared memory and scans
directly ProcArray entries.

> Anyway, it's not a huge deal to me. If Michael doesn't want to
> backpatch it, it's his call, and I don't have the cycles to do it myself
> right now either. If some other committer cares about it, well ...

New wait events on HEAD are adapted to HEAD in my opinion, so I would
keep the code as it is now. If anybody wishes to back-patch the change,
of course feel free to do so.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2018-07-04 01:13:06 Re: pgsql: Clarify use of temporary tables within partition trees
Previous Message Peter Eisentraut 2018-07-03 21:33:57 pgsql: Add $Test::Builder::Level to pgbench test functions

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-03 22:52:48 Re: Non-reserved replication slots and slot advancing
Previous Message Thomas Munro 2018-07-03 21:58:17 Cache invalidation after authentication (on-the-fly role creation)