Re: pgsql: Add wait event for fsync of WAL segments

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add wait event for fsync of WAL segments
Date: 2018-07-03 19:18:45
Message-ID: 20180703191845.6dcmu5ku56wsqgoe@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2018-07-03 15:13:20 -0400, Alvaro Herrera wrote:
> Are the numerical values actually exposed to the world? I thought the
> only way to this info was through the system views, which surely expose
> the names, not the numbers.

There's at least some work at high frequency sampling of these, and I
assume that's not going through SQL, but rather C functions.

> If reading wait events is actually possible, then it seems easy to
> backpatch this in pg10 by putting the new value at the end of the
> relevant enum, yeah.

Honestly, I don't really see an argument for backpatching this. If
people started measuring it might even invalidate their stats.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-03 20:12:23 Re: pgsql: Add wait event for fsync of WAL segments
Previous Message Alvaro Herrera 2018-07-03 19:13:20 Re: pgsql: Add wait event for fsync of WAL segments

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-03 20:12:23 Re: pgsql: Add wait event for fsync of WAL segments
Previous Message Alvaro Herrera 2018-07-03 19:13:20 Re: pgsql: Add wait event for fsync of WAL segments