| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Tips on committing |
| Date: | 2018-07-02 16:05:47 |
| Message-ID: | 20180702160546.GB27724@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Greetings,
* Peter Geoghegan (pg(at)bowt(dot)ie) wrote:
> FWIW, I developed a document on committing for my own reference, with
> some help from Andres. A lot of it is about commit message style, the
> use of fields, and so on. But I've also developed a check list for
> committing, knowing that there are a few classic mistakes that
> committers will make from time to time despite knowing better. These
> are worth checking against mechanically, IMV. Here are some actual
> examples from this document that I refer to:
Good list.
> * Do a dry run before really pushing by using --dry-run.
In addition to this, I'd recommend using 'git show' on the results of
the --dry-run, so that you see what you're really about to push.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-07-02 16:21:50 | Re: Tips on committing |
| Previous Message | Arseny Sher | 2018-07-02 15:52:09 | Re: pgsql: Fix "base" snapshot handling in logical decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-07-02 16:06:22 | Re: [HACKERS] [PATCH] kNN for SP-GiST |
| Previous Message | Alvaro Hernandez | 2018-07-02 16:03:42 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |