| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove mention in docs that foreign keys on partitioned tables are not supported |
| Date: | 2018-06-27 19:18:19 |
| Message-ID: | 20180627191819.6g73wu7ck23fdhv6@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jun-19, Amit Langote wrote:
> In CreateTrigger(), 86f575948c7 did this.
>
> - values[Anum_pg_trigger_tgisinternal - 1] = BoolGetDatum(isInternal);
> + values[Anum_pg_trigger_tgisinternal - 1] = BoolGetDatum(isInternal ||
> in_partition);
>
> I'm not sure why it had to be done, but undoing this change doesn't seem
> to break any regression tests (neither those added by 86f575948c7 nor of
> the partitioned table foreign key commit). Did we really intend to change
> the meaning of tginternal like this here?
I'm pretty sure pg_dump breaks if you turn that flag off for triggers in
partitions, because pg_dump is going to emit commands to create those
triggers, and those fail.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-06-27 19:18:45 | Re: Allow cancelling VACUUM of nbtrees with corrupted right links |
| Previous Message | Andres Freund | 2018-06-27 19:16:29 | Allow cancelling VACUUM of nbtrees with corrupted right links |