| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Portability concerns over pq_sendbyte? |
| Date: | 2018-06-27 09:40:46 |
| Message-ID: | 20180627094046.GE2667@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 26, 2018 at 11:51:49PM -0700, Andres Freund wrote:
> Looking at surrounding code I found a few more oddities, but of older
> vintage:
> - pq_sendfloat4 uses an uint32 in the union, but float8 uses a int64.
> - same with pq_getmsgfloat[48]
> - pq_getmsgint64 returns a int64, should probably also be uint64
>
> Given they're practially harmless I'm inclined to only fix them in
> master?
Doing those three things on HEAD only looks like a good plan to me. I
have not spotted more inconsistencies in pqformat.c.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajkumar Raghuwanshi | 2018-06-27 09:42:14 | alter index WITH ( storage_parameter = value [, ... ] ) for partition index. |
| Previous Message | Michael Paquier | 2018-06-27 09:36:46 | Re: Small fixes about backup history file in doc and pg_standby |