From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Don Seiler <don(at)seiler(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Include application_name in "connection authorized" log message |
Date: | 2018-06-22 19:26:06 |
Message-ID: | 20180622192606.lsxo2l5nhixf5dk2@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2018-Jun-22, Andres Freund wrote:
> On 2018-06-22 12:16:18 -0400, Robert Haas wrote:
> > OK, that makes more sense, but I'm still skeptical of adding a special
> > case particularly for application_name.
>
> I think a fair argument could be made that you'd want to have
> application_name logged exactly once, not in every line. Just to cope
> with log volume. With decent log analysis tools once is enough.
Seems harder than it sounds ... because if the user turns off
log_connections then it's not longer in the log. And what about the
application changing it after the fact? One idea would be to have a log
line designed specifically to be printed once at connection start (if
not log_connections) and then once immediately after it changes. Am I
the only one for whom this sounds like overengineering?
I think the idea is nice, but I'm not sure about feasibility.
I further think that the idea in the OP is sound enough.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-06-22 19:38:07 | Re: [PATCH] Include application_name in "connection authorized" log message |
Previous Message | sixela | 2018-06-22 19:20:13 | Re: pg_verify_checksums review |