| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | alvherre(at)2ndquadrant(dot)com, simon(at)2ndquadrant(dot)com, a(dot)sher(at)postgrespro(dot)ru, sawada(dot)mshk(at)gmail(dot)com, k(dot)knizhnik(at)postgrespro(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Possible bug in logical replication. |
| Date: | 2018-06-22 09:39:54 |
| Message-ID: | 20180622093954.GB16899@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 22, 2018 at 04:33:12PM +0900, Kyotaro HORIGUCHI wrote:
> pg_advance_replication_slots can advance uninitialized physical
> slots and that might not be good. (Logical slots always have
> initial invalid values in thw two lsn columns.)
The current logic is careful that users willing to move to a new
position cannot move in the future, but the logic is visibly wanted to
accept past values. Petr, what do you think? KeepLogSeg() won't return
negative values so some applications may take advantage of that. Or
should advancing be simply disabled for non-initialized slots?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-06-22 09:49:46 | Re: Wrong cost estimation for foreign tables join with use_remote_estimate disabled |
| Previous Message | Amit Kapila | 2018-06-22 09:23:36 | Re: add default parallel query to v10 release notes? (Re: [PERFORM] performance drop after upgrade (9.6 > 10)) |