| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fast default stuff versus pg_upgrade |
| Date: | 2018-06-21 21:10:06 |
| Message-ID: | 20180621211006.6mqp5jbrgl7dx3in@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In terms of pgindent, I'm surprised about these lines:
+ missingval = OidFunctionCall3(
+ F_ARRAY_IN,
Why did you put a newline there? In ancient times there was a reason
for that in some cases, because pgindent would move the argument to the
left of the open parens, but it doesn't do that anymore and IMO it's
just ugly. We have quite a few leftovers from this ancient practice,
I've been thinking about removing these ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-21 21:20:31 | Re: Fast default stuff versus pg_upgrade |
| Previous Message | David Gershuni | 2018-06-21 20:44:56 | Re: Spilling hashed SetOps and aggregates to disk |