|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>|
|Cc:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, amul sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>|
|Subject:||Re: Partitioning with temp tables is broken|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, Jun 19, 2018 at 04:27:08PM +0900, Amit Langote wrote:
> Looking at what changed from my patch:
> - One cannot have both temporary and permanent relations in a given
> - partition tree. That is, if the root partitioned table is permanent,
> - so must be its partitions at all levels and vice versa.
> + Mixing temporary and permanent relations in the same partition tree
> + is not allowed. Hence, if the root partitioned table is permanent,
> + so must be its partitions at all levels and vice versa for temporary
> + relations.
> The "vice versa" usage in my patch wasn't perhaps right to begin with, but
> the way your patch extends it make it a bit more confusing. Maybe we
> should write it as: "... and likewise if the root partitioned table is
I like you wording better here.
> Except the point above about documentation, I'm fine with your patch.
Thanks. I'll look at that again hopefully tomorrow or the day after and
address things for both HEAD and REL_10_STABLE. From what I can see I
don't expect any major issues but an extra lookup may catch something,
and I am out of fuel for the day..
|Next Message||Amit Langote||2018-06-19 08:06:00||documenting forbidden expressions in column defaults|
|Previous Message||Konstantin Knizhnik||2018-06-19 07:54:38||Re: libpq compression|