Re: AtEOXact_ApplyLauncher() and subtransactions

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>
Subject: Re: AtEOXact_ApplyLauncher() and subtransactions
Date: 2018-06-14 16:28:54
Message-ID: 20180614162854.egmj6k3ks2jlez45@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Jun-05, Amit Khandekar wrote:

> When a SUBSCRIPTION is altered, then the currently running
> table-synchronization workers that are no longer needed for the
> altered subscription, are terminated. This is done by the function
> AtEOXact_ApplyLauncher() inside CommitTransaction(). So during each
> ALTER-SUBSCRIPTION command, the on_commit_stop_workers list is
> appended with new set of workers to be stopped. And then at commit,
> AtEOXact_ApplyLauncher() stops the workers in the list.
>
> But there is no handling for sub-transaction abort.

Peter, any comments here?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-06-14 16:35:20 Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)"
Previous Message Tom Lane 2018-06-14 16:24:15 Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)"